Skip to content

Commit

Permalink
fix: gasFeeEstimates property undefined (#29312)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This PR fixes an issue created by Sentry where the property
`gasFeeEstimates` is `undefined`.
Added an early return when the property is `undefined` and covered the
scenario with unit tests.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29312?quickstart=1)

## **Related issues**

Fixes: #27501
#27241

## **Manual testing steps**

1. Go to this test dapp
2. Block requests against gas-api
3. Start a send or contract interaction 
4. Verify the console

## **Screenshots/Recordings**


[block-gas-api.webm](https://github.com/user-attachments/assets/1c3cf638-905e-4df9-b875-84f0056979b1)


<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
vinistevam authored Dec 20, 2024
1 parent 8a6f4f9 commit 3fd27a9
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
12 changes: 12 additions & 0 deletions ui/pages/confirmations/hooks/useTransactionFunction.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,16 @@ describe('useMaxPriorityFeePerGasInput', () => {
userFeeLevel: 'dappSuggested',
});
});

it('returns early when gasFeeEstimates is undefined', () => {
const mockUpdateTransaction = jest
.spyOn(Actions, 'updateTransactionGasFees')
.mockImplementation(() => ({ type: '' }));

const { result } = renderUseTransactionFunctions({
gasFeeEstimates: undefined,
});
result.current.updateTransactionUsingEstimate(GasRecommendations.low);
expect(mockUpdateTransaction).not.toHaveBeenCalled();
});
});
3 changes: 2 additions & 1 deletion ui/pages/confirmations/hooks/useTransactionFunctions.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,10 @@ export const useTransactionFunctions = ({

const updateTransactionUsingEstimate = useCallback(
(gasFeeEstimateToUse) => {
if (!gasFeeEstimates[gasFeeEstimateToUse]) {
if (!gasFeeEstimates?.[gasFeeEstimateToUse]) {
return;
}

const { suggestedMaxFeePerGas, suggestedMaxPriorityFeePerGas } =
gasFeeEstimates[gasFeeEstimateToUse];
updateTransaction({
Expand Down

0 comments on commit 3fd27a9

Please sign in to comment.