Skip to content

Commit

Permalink
test: Removed step from e2e tests (#25910)
Browse files Browse the repository at this point in the history
The following Enhanced Transaction Protection modal has been removed
from onboarding steps so I also had to remove the step from the e2e test
automation script

<img width="358" alt="Screenshot 2024-07-17 at 10 14 06 PM"
src="https://github.com/user-attachments/assets/8a78d27c-3397-4039-aee6-ae0a7ae7023c">


## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25910?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
davibroc authored and Gudahtt committed Aug 27, 2024
1 parent ab3c9b6 commit 39c4f51
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/e2e/playwright/shared/pageObjects/signup-page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,5 @@ export class SignUpPage {
await this.gotItBtn.click();
await this.nextBtn.click();
await this.doneBtn.click();
await this.enableButton.click();
}
}

0 comments on commit 39c4f51

Please sign in to comment.