Skip to content

Commit

Permalink
fix: 'Metamask' casing on token details page (#29250)
Browse files Browse the repository at this point in the history
## **Description**

Fixes the casing of 'Metamask' to 'MetaMask' on the token details page.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29250?quickstart=1)

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-399

## **Manual testing steps**

1. Click on an erc20 token
2. Verify token lists section uses casing 'MetaMask'

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="327" alt="Screenshot 2024-12-16 at 1 27 31 PM"
src="https://github.com/user-attachments/assets/5faee32d-21a2-474f-b1a2-bf8eebd03297"
/>

### **After**

<img width="325" alt="Screenshot 2024-12-16 at 1 27 09 PM"
src="https://github.com/user-attachments/assets/d3090007-e72f-4ee6-83c9-8006596c53bf"
/>

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
bergeron authored Dec 18, 2024
1 parent d630827 commit 26f7c5a
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions ui/pages/asset/components/asset-page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export type Asset = (
/** The number of decimal places to move left when displaying balances */
decimals: number;
/** An array of token list sources the asset appears in, e.g. [1inch,Sushiswap] */
aggregators?: [];
aggregators?: string[];
}
) & {
/** The hexadecimal chain id */
Expand Down Expand Up @@ -332,7 +332,13 @@ const AssetPage = ({
>
{t('tokenList')}
</Text>
<Text>{asset.aggregators.join(', ')}</Text>
<Text>
{asset.aggregators
.map((agg) =>
agg.replace(/^metamask$/iu, 'MetaMask'),
)
.join(', ')}
</Text>
</Box>
)}
</Box>
Expand Down

0 comments on commit 26f7c5a

Please sign in to comment.