feat: test-lint-lockfile

MetaMask · Dec 17, 2024 · 131caab · 131caab
1 parent 676d0eb
commit 131caab
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 18 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -180,9 +180,6 @@ workflows:
       - prep-build-ts-migration-dashboard:
           requires:
             - prep-deps
-      - test-lint-lockfile:
-          requires:
-            - prep-deps
       - test-e2e-chrome-webpack:
           <<: *main_master_rc_only
           requires:
@@ -274,7 +271,6 @@ workflows:
             - validate-lavamoat-allow-scripts
             - validate-lavamoat-policy-build
             - validate-lavamoat-policy-webapp
-            - test-lint-lockfile
             - validate-source-maps
             - validate-source-maps-beta
             - validate-source-maps-flask
@@ -950,20 +946,6 @@ jobs:
           name: Test Storybook
           command: yarn test-storybook:ci
 
-  test-lint-lockfile:
-    executor: node-browsers-medium-plus
-    steps:
-      - run: *shallow-git-clone-and-enable-vnc
-      - run: sudo corepack enable
-      - attach_workspace:
-          at: .
-      - run:
-          name: lockfile-lint
-          command: yarn lint:lockfile
-      - run:
-          name: check yarn resolutions
-          command: yarn --check-resolutions
-
   test-e2e-chrome-webpack:
     executor: node-browsers-medium-plus
     parallelism: 20

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -41,6 +41,10 @@ jobs:
     name: Test lint changelog
     uses: ./.github/workflows/test-lint-changelog.yml
 
+  test-lint-lockfile:
+    name: Test lint lockfile
+    uses: ./.github/workflows/test-lint-lockfile.yml
+
   run-tests:
     name: Run tests
     uses: ./.github/workflows/run-tests.yml
@@ -69,6 +73,7 @@ jobs:
       - test-deps-depcheck
       - test-lint
       - test-lint-changelog
+      - test-lint-lockfile
       - run-tests
       - wait-for-circleci-workflow-status
       - publish-prerelease

diff --git a/.github/workflows/test-lint-lockfile.yml b/.github/workflows/test-lint-lockfile.yml
@@ -0,0 +1,21 @@
+name: Test lint lockfile
+
+on:
+  workflow_call:
+
+jobs:
+  test-lint-lockfile:
+    name: Test lint lockfile
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup environment
+        uses: metamask/github-tools/.github/actions/setup-environment@main
+
+      - name: Lint lockfile
+        run: yarn lint:lockfile
+
+      - name: Check yarn resolutions
+        run: yarn --check-resolutions