Skip to content

Commit

Permalink
fix: Remove use of boolean value for metrics properties (#29315)
Browse files Browse the repository at this point in the history
## **Description**

Remove use of boolean value for metrics property.

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3811

## **Manual testing steps**
NA

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
jpuri authored Dec 18, 2024
1 parent 5aa2962 commit 12dcf14
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const useTrackERC20WithoutDecimalInformation = (
event: MetaMetricsEventName.SimulationIncompleteAssetDisplayed,
category: MetaMetricsEventCategory.Confirmations,
properties: {
token_decimals_available: false,
token_decimals_available: 'not_available',
asset_address: tokenAddress,
asset_type: TokenStandard.ERC20,
chain_id: chainId,
Expand Down

0 comments on commit 12dcf14

Please sign in to comment.