Skip to content

Commit

Permalink
chore(deps): bump @metamask/eth-trezor-keyring to ^6.0.0 (#27689)
Browse files Browse the repository at this point in the history 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps `@metamask/eth-trezor-keyring` from `^3.1.3` to `^6.0.0`. 

```
## [6.0.0]

### Added

- **BREAKING:** Add ESM build ([#40](MetaMask/accounts#40))
  - It's no longer possible to import files from `./dist` directly.

## [5.0.0]

### Changed

- **BREAKING**: Bump `@metamask/eth-sig-util` dependency from `^7.0.3` to `^8.0.0` ([#79](MetaMask/accounts#79))
  - `signTypedData` no longer support `number` for addresses, see [here](https://github.com/MetaMask/eth-sig-util/blob/main/CHANGELOG.md#800).

## [4.0.0]

### Changed

- **BREAKING**: `addAccounts` will now only return newly created accounts ([#64](MetaMask/accounts#64))
  - This keyring was initially returning every accounts (previous and new ones), which is different from what is expected in the [`Keyring` interface].(https://github.com/MetaMask/utils/blob/v9.2.1/src/keyring.ts#L65)
```

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27689?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

These changes directly impact Trezor devices:
1. Add one or more Trezor accounts
2. Sign message
3. Sign typed data
4. Sign transaction
5. Remove Trezor accounts

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
@mikesposito
mikesposito authored Jan 9, 2025
1 parent 55a7ffa commit 0f60500
Show file tree
Hide file tree
Showing 6 changed files with 222 additions and 79 deletions.
65 changes: 49 additions & 16 deletions lavamoat/browserify/beta/policy.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@
"console": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/notification-services-controller>firebase>@firebase/messaging": {
Expand Down Expand Up @@ -584,7 +584,7 @@
"@metamask/notification-services-controller>firebase>@firebase/installations": true,
"@metamask/notification-services-controller>firebase>@firebase/util": true,
"@metamask/notification-services-controller>firebase>@firebase/app>idb": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/notification-services-controller>firebase>@firebase/util": {
Expand Down Expand Up @@ -634,7 +634,7 @@
"ethereumjs-util>ethereum-cryptography>bs58check": true,
"buffer": true,
"browserify>buffer": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@keystonehq/metamask-airgapped-keyring": {
Expand Down Expand Up @@ -815,6 +815,12 @@
"@metamask/eth-snap-keyring>@metamask/eth-sig-util>@metamask/abi-utils>@metamask/utils": true
}
},
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/abi-utils": {
"packages": {
"@metamask/utils>@metamask/superstruct": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/utils": true
}
},
"@metamask/keyring-controller>@metamask/eth-sig-util>@metamask/abi-utils": {
"packages": {
"@metamask/utils>@metamask/superstruct": true,
Expand Down Expand Up @@ -1121,6 +1127,17 @@
"@metamask/eth-sig-util>tweetnacl": true
}
},
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util": {
"packages": {
"@ethereumjs/tx>@ethereumjs/util": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/abi-utils": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/utils": true,
"@metamask/utils>@scure/base": true,
"browserify>buffer": true,
"@ethereumjs/tx>ethereum-cryptography": true,
"@metamask/eth-sig-util>tweetnacl": true
}
},
"@metamask/keyring-controller>@metamask/eth-sig-util": {
"packages": {
"@ethereumjs/tx>@ethereumjs/util": true,
Expand Down Expand Up @@ -1191,6 +1208,7 @@
"packages": {
"@ethereumjs/tx": true,
"@ethereumjs/tx>@ethereumjs/util": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util": true,
"@metamask/eth-trezor-keyring>@trezor/connect-plugin-ethereum": true,
"@trezor/connect-web": true,
"browserify>buffer": true,
Expand Down Expand Up @@ -2061,6 +2079,21 @@
"semver": true
}
},
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/utils": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
},
"packages": {
"@metamask/utils>@metamask/superstruct": true,
"@noble/hashes": true,
"@metamask/utils>@scure/base": true,
"browserify>buffer": true,
"nock>debug": true,
"@metamask/utils>pony-cause": true,
"semver": true
}
},
"@metamask/keyring-controller>@metamask/eth-sig-util>@metamask/utils": {
"globals": {
"TextDecoder": true,
Expand Down Expand Up @@ -2684,13 +2717,13 @@
"packages": {
"@trezor/connect-web>@trezor/connect-common>@trezor/env-utils": true,
"@trezor/connect-web>@trezor/utils": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/eth-trezor-keyring>@trezor/connect-plugin-ethereum": {
"packages": {
"@metamask/eth-sig-util": true,
"@swc/helpers>tslib": true
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util": true,
"tslib": true
}
},
"@trezor/connect-web": {
Expand Down Expand Up @@ -2721,7 +2754,7 @@
"@trezor/connect-web>@trezor/connect": true,
"@trezor/connect-web>@trezor/utils": true,
"webpack>events": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@trezor/connect-web>@trezor/connect": {
Expand All @@ -2730,7 +2763,7 @@
"@trezor/connect-web>@trezor/connect>@trezor/schema-utils": true,
"@trezor/connect-web>@trezor/connect>@trezor/transport": true,
"@trezor/connect-web>@trezor/utils": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@trezor/connect-web>@trezor/connect-common>@trezor/env-utils": {
Expand All @@ -2747,7 +2780,7 @@
},
"packages": {
"process": true,
"@swc/helpers>tslib": true,
"tslib": true,
"@trezor/connect-web>@trezor/connect-common>@trezor/env-utils>ua-parser-js": true
}
},
Expand All @@ -2756,7 +2789,7 @@
"@trezor/connect-web>@trezor/connect>@trezor/schema-utils": true,
"browserify>buffer": true,
"@trezor/connect-web>@trezor/connect>@trezor/protobuf>protobufjs": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@trezor/connect-web>@trezor/connect>@trezor/schema-utils": {
Expand Down Expand Up @@ -2786,7 +2819,7 @@
"@trezor/connect-web>@trezor/utils>bignumber.js": true,
"browserify>buffer": true,
"webpack>events": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@welldone-software/why-did-you-render": {
Expand Down Expand Up @@ -2899,7 +2932,7 @@
"setTimeout": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/transaction-controller>@metamask/nonce-tracker>async-mutex": {
Expand All @@ -2908,7 +2941,7 @@
"setTimeout": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"string.prototype.matchall>es-abstract>available-typed-arrays": {
Expand Down Expand Up @@ -3810,7 +3843,7 @@
"setTimeout": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"browserify>util>which-typed-array>for-each": {
Expand Down Expand Up @@ -5324,7 +5357,7 @@
"document.getSelection": true
}
},
"@swc/helpers>tslib": {
"tslib": {
"globals": {
"SuppressedError": true,
"define": true
Expand Down Expand Up @@ -5412,7 +5445,7 @@
"packages": {
"react-focus-lock>use-sidecar>detect-node-es": true,
"react": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"readable-stream>util-deprecate": {
Expand Down
65 changes: 49 additions & 16 deletions lavamoat/browserify/flask/policy.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@
"console": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/notification-services-controller>firebase>@firebase/messaging": {
Expand Down Expand Up @@ -584,7 +584,7 @@
"@metamask/notification-services-controller>firebase>@firebase/installations": true,
"@metamask/notification-services-controller>firebase>@firebase/util": true,
"@metamask/notification-services-controller>firebase>@firebase/app>idb": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/notification-services-controller>firebase>@firebase/util": {
Expand Down Expand Up @@ -634,7 +634,7 @@
"ethereumjs-util>ethereum-cryptography>bs58check": true,
"buffer": true,
"browserify>buffer": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@keystonehq/metamask-airgapped-keyring": {
Expand Down Expand Up @@ -815,6 +815,12 @@
"@metamask/eth-snap-keyring>@metamask/eth-sig-util>@metamask/abi-utils>@metamask/utils": true
}
},
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/abi-utils": {
"packages": {
"@metamask/utils>@metamask/superstruct": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/utils": true
}
},
"@metamask/keyring-controller>@metamask/eth-sig-util>@metamask/abi-utils": {
"packages": {
"@metamask/utils>@metamask/superstruct": true,
Expand Down Expand Up @@ -1121,6 +1127,17 @@
"@metamask/eth-sig-util>tweetnacl": true
}
},
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util": {
"packages": {
"@ethereumjs/tx>@ethereumjs/util": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/abi-utils": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/utils": true,
"@metamask/utils>@scure/base": true,
"browserify>buffer": true,
"@ethereumjs/tx>ethereum-cryptography": true,
"@metamask/eth-sig-util>tweetnacl": true
}
},
"@metamask/keyring-controller>@metamask/eth-sig-util": {
"packages": {
"@ethereumjs/tx>@ethereumjs/util": true,
Expand Down Expand Up @@ -1191,6 +1208,7 @@
"packages": {
"@ethereumjs/tx": true,
"@ethereumjs/tx>@ethereumjs/util": true,
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util": true,
"@metamask/eth-trezor-keyring>@trezor/connect-plugin-ethereum": true,
"@trezor/connect-web": true,
"browserify>buffer": true,
Expand Down Expand Up @@ -2061,6 +2079,21 @@
"semver": true
}
},
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util>@metamask/utils": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
},
"packages": {
"@metamask/utils>@metamask/superstruct": true,
"@noble/hashes": true,
"@metamask/utils>@scure/base": true,
"browserify>buffer": true,
"nock>debug": true,
"@metamask/utils>pony-cause": true,
"semver": true
}
},
"@metamask/keyring-controller>@metamask/eth-sig-util>@metamask/utils": {
"globals": {
"TextDecoder": true,
Expand Down Expand Up @@ -2684,13 +2717,13 @@
"packages": {
"@trezor/connect-web>@trezor/connect-common>@trezor/env-utils": true,
"@trezor/connect-web>@trezor/utils": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/eth-trezor-keyring>@trezor/connect-plugin-ethereum": {
"packages": {
"@metamask/eth-sig-util": true,
"@swc/helpers>tslib": true
"@metamask/eth-trezor-keyring>@metamask/eth-sig-util": true,
"tslib": true
}
},
"@trezor/connect-web": {
Expand Down Expand Up @@ -2721,7 +2754,7 @@
"@trezor/connect-web>@trezor/connect": true,
"@trezor/connect-web>@trezor/utils": true,
"webpack>events": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@trezor/connect-web>@trezor/connect": {
Expand All @@ -2730,7 +2763,7 @@
"@trezor/connect-web>@trezor/connect>@trezor/schema-utils": true,
"@trezor/connect-web>@trezor/connect>@trezor/transport": true,
"@trezor/connect-web>@trezor/utils": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@trezor/connect-web>@trezor/connect-common>@trezor/env-utils": {
Expand All @@ -2747,7 +2780,7 @@
},
"packages": {
"process": true,
"@swc/helpers>tslib": true,
"tslib": true,
"@trezor/connect-web>@trezor/connect-common>@trezor/env-utils>ua-parser-js": true
}
},
Expand All @@ -2756,7 +2789,7 @@
"@trezor/connect-web>@trezor/connect>@trezor/schema-utils": true,
"browserify>buffer": true,
"@trezor/connect-web>@trezor/connect>@trezor/protobuf>protobufjs": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@trezor/connect-web>@trezor/connect>@trezor/schema-utils": {
Expand Down Expand Up @@ -2786,7 +2819,7 @@
"@trezor/connect-web>@trezor/utils>bignumber.js": true,
"browserify>buffer": true,
"webpack>events": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"@welldone-software/why-did-you-render": {
Expand Down Expand Up @@ -2899,7 +2932,7 @@
"setTimeout": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"@metamask/transaction-controller>@metamask/nonce-tracker>async-mutex": {
Expand All @@ -2908,7 +2941,7 @@
"setTimeout": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"string.prototype.matchall>es-abstract>available-typed-arrays": {
Expand Down Expand Up @@ -3810,7 +3843,7 @@
"setTimeout": true
},
"packages": {
"@swc/helpers>tslib": true
"tslib": true
}
},
"browserify>util>which-typed-array>for-each": {
Expand Down Expand Up @@ -5324,7 +5357,7 @@
"document.getSelection": true
}
},
"@swc/helpers>tslib": {
"tslib": {
"globals": {
"SuppressedError": true,
"define": true
Expand Down Expand Up @@ -5412,7 +5445,7 @@
"packages": {
"react-focus-lock>use-sidecar>detect-node-es": true,
"react": true,
"@swc/helpers>tslib": true
"tslib": true
}
},
"readable-stream>util-deprecate": {
Expand Down
Loading

0 comments on commit 0f60500

Please sign in to comment.