fix: gasFeeEstimates property undefined

MetaMask · Dec 18, 2024 · 0c8d002 · 0c8d002
1 parent edd7b25
commit 0c8d002
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/ui/pages/confirmations/hooks/useTransactionFunction.test.js b/ui/pages/confirmations/hooks/useTransactionFunction.test.js
@@ -164,4 +164,16 @@ describe('useMaxPriorityFeePerGasInput', () => {
       userFeeLevel: 'dappSuggested',
     });
   });
+
+  it('returns early when gasFeeEstimates is undefined', () => {
+    const mockUpdateTransaction = jest
+      .spyOn(Actions, 'updateTransactionGasFees')
+      .mockImplementation(() => ({ type: '' }));
+
+    const { result } = renderUseTransactionFunctions({
+      gasFeeEstimates: undefined,
+    });
+    result.current.updateTransactionUsingEstimate(GasRecommendations.low);
+    expect(mockUpdateTransaction).not.toHaveBeenCalled();
+  });
 });
diff --git a/ui/pages/confirmations/hooks/useTransactionFunctions.js b/ui/pages/confirmations/hooks/useTransactionFunctions.js
@@ -201,9 +201,14 @@ export const useTransactionFunctions = ({
 
   const updateTransactionUsingEstimate = useCallback(
     (gasFeeEstimateToUse) => {
+      if (!gasFeeEstimates) {
+        return;
+      }
+
       if (!gasFeeEstimates[gasFeeEstimateToUse]) {
         return;
       }
+
       const { suggestedMaxFeePerGas, suggestedMaxPriorityFeePerGas } =
         gasFeeEstimates[gasFeeEstimateToUse];
       updateTransaction({