refactor: select account only when is new

MetaMask · Aug 1, 2023 · 027707a · 027707a
1 parent d93be8f
commit 027707a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -3378,7 +3378,7 @@ export default class MetamaskController extends EventEmitter {
    * Adds a new account to the default (first) HD seed phrase Keyring.
    *
    * @param accountCount
-   * @returns {} keyState
+   * @returns {Promise<string>} The address of the newly-created account.
    */
   async addNewAccount(accountCount) {
     const isActionMetricsQueueE2ETest =
@@ -3388,10 +3388,15 @@ export default class MetamaskController extends EventEmitter {
       await new Promise((resolve) => setTimeout(resolve, 5_000));
     }
 
+    const { identities: oldIdentities } =
+      this.preferencesController.store.getState();
+
     const { addedAccountAddress } =
       await this.coreKeyringController.addNewAccount(accountCount);
 
-    this.preferencesController.setSelectedAddress(addedAccountAddress);
+    if (Object.keys(oldIdentities).length === accountCount) {
+      this.preferencesController.setSelectedAddress(addedAccountAddress);
+    }
 
     return addedAccountAddress;
   }