refactor: Unflatten selectors and convert to TypeScript #54141
Annotations
10 errors and 11 warnings
Lint:
app/scripts/controllers/metametrics-controller.test.ts#L1409
Object literal may only specify known properties, and 'internalAccounts' does not exist in type 'BackgroundStateProxy'.
|
Lint:
app/scripts/controllers/metametrics-controller.test.ts#L1527
Object literal may only specify known properties, and 'ledgerTransportType' does not exist in type 'BackgroundStateProxy'.
|
Lint:
app/scripts/controllers/metametrics-controller.test.ts#L1585
Object literal may only specify known properties, and 'ledgerTransportType' does not exist in type 'BackgroundStateProxy'.
|
Lint:
app/scripts/controllers/metametrics-controller.test.ts#L1653
Object literal may only specify known properties, and 'ledgerTransportType' does not exist in type 'BackgroundStateProxy'.
|
Lint:
app/scripts/controllers/metametrics-controller.test.ts#L1702
Object literal may only specify known properties, and 'ledgerTransportType' does not exist in type 'BackgroundStateProxy'.
|
Lint:
app/scripts/controllers/metametrics-controller.ts#L547
Unused '@ts-expect-error' directive.
|
Lint:
app/scripts/migrations/131.1.ts#L51
Argument of type 'string' is not assignable to parameter of type '"0x61" | "0xaa37dc" | "0x15eb" | "0xa869" | "0xaa36a7" | "0x4268" | "0xe705" | "0x13882" | "0x14a34" | "0x2a15c3083" | "0xaef3" | "0x12c" | "0x138b" | "0x515" | "0xe708" | "0x8274f" | "0x66eee"'.
|
Lint:
app/scripts/migrations/131.1.ts#L78
Argument of type 'string' is not assignable to parameter of type '"mainnet.infura.io" | "linea-mainnet.infura.io" | "polygon-mainnet.infura.io" | "base-mainnet.infura.io" | "blast-mainnet.infura.io" | "optimism-mainnet.infura.io" | "arbitrum-mainnet.infura.io" | ... 7 more ... | "scroll-mainnet.infura.io"'.
|
Lint:
shared/modules/selectors/index.test.ts#L84
Argument of type '{ metamask: { selectedNetworkClientId: string; networkConfigurationsByChainId: Record<`0x${string}`, NetworkConfiguration>; networksMetadata: NetworksMetadata; ... 4 more ...; smartTransactionsState: { ...; }; }; }' is not assignable to parameter of type 'MetaMaskSliceControllerState<"PreferencesController">'.
|
Lint:
shared/modules/selectors/index.test.ts#L95
Argument of type '{ metamask: { preferences: { smartTransactionsOptInStatus: boolean; }; }; }' is not assignable to parameter of type 'MetaMaskSliceControllerState<"PreferencesController">'.
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Lint:
app/scripts/controllers/swaps/swaps.test.ts#L1265
Some tests seem to be commented
|
Lint:
app/scripts/controllers/swaps/swaps.test.ts#L1286
Some tests seem to be commented
|
Lint:
app/scripts/controllers/swaps/swaps.test.ts#L1306
Some tests seem to be commented
|
Lint:
app/scripts/controllers/swaps/swaps.test.ts#L1390
Some tests seem to be commented
|
Lint:
app/scripts/controllers/swaps/swaps.test.ts#L1406
Some tests seem to be commented
|
Lint:
app/scripts/controllers/swaps/swaps.test.ts#L1429
Some tests seem to be commented
|
Lint:
shared/modules/bridge-utils/bridge.util.test.ts#L152
Replace toThrowError() with its canonical name of toThrow()
|
Lint:
shared/modules/bridge-utils/bridge.util.test.ts#L226
Replace toThrowError() with its canonical name of toThrow()
|
Lint:
ui/components/app/assets/nfts/nfts-items/nfts-items.js#L154
React Hook useEffect has missing dependencies: 'collections', 'collectionsKeys', and 'getAssetImageUrlAndUpdate'. Either include them or remove the dependency array
|
Lint:
ui/components/app/detected-token/detected-token.js#L117
React Hook useEffect has a missing dependency: 'tokensListDetected'. Either include it or remove the dependency array
|
Loading