Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move @metamask/utils from dependencies to devDependencies #209

Merged
merged 1 commit into from
Nov 3, 2023
Merged

chore: move @metamask/utils from dependencies to devDependencies #209

merged 1 commit into from
Nov 3, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 2, 2023 •
edited
Loading

The package @metamask/utils is only directly used in tests and does not need to be in dependencies. This moves it to devDependencies.

It became unused as of #156 .

@legobeat legobeat changed the title chore: move @metamask/utils from deps to devDeps chore: move @metamask/utils from dependencies to devDependencies Nov 2, 2023
@legobeat legobeat mentioned this pull request Nov 2, 2023
Merged
3 tasks
@legobeat legobeat marked this pull request as ready for review November 2, 2023 01:44
@legobeat legobeat requested a review from a team as a code owner November 2, 2023 01:44
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Nov 2, 2023
mcmire
mcmire approved these changes Nov 2, 2023
View reviewed changes
Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Makes sense.

MajorLift
MajorLift approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit 059e9b7 into MetaMask:main Nov 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajorLift MajorLift MajorLift approved these changes

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @mcmire @MajorLift