fix ledger unlocking using hdPath in accountDetails #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
reviewed
May 16, 2022
| @@ -133,8 +133,10 @@ class LedgerBridgeKeyring extends EventEmitter { | |||
| }, | |||
| ({ success, payload }) => { | |||
| if (success) { | |||
There was a problem hiding this comment.
Is it possible to add a unit test for each of the true and false cases for updateHdk? (Or update existing tests of methods that call unlock to ensure that they would fail without this change)
There was a problem hiding this comment.
yep I added test cases
danjm
requested changes
May 16, 2022
|
from QA side - working fine @jpuri |
darkwing
approved these changes
May 24, 2022
brad-decker
reviewed
May 25, 2022
brad-decker
approved these changes
May 25, 2022
danjm
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: MetaMask/metamask-extension#6012