intToHex util produces invalid Quantities

[josepot]

Hi and thank you for maintaining this library!

Our dApp stopped working once we tested it against a recently deployed tenderly fork.

After spending some hours trying to find the root cause, it turns out that the problem is that some of the calls that metamask makes to eth_getLogs (as a result of a logs subscription) have an invalid payload.

An example of an invalid payload produced from metamask in order to query the logs of the newest block:

{
    "id": 2265185671823508,
    "jsonrpc": "2.0",
    "method": "eth_getLogs",
    "params": [
        {
            "fromBlock": "0x01470640",
            "toBlock": "0x1470641",
            "address": [
                "0xda10009cbd5d07dd0cecc66161fc93d7c9000da1"
            ],
            "topics": [
                "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef"
            ]
        }
    ]
}

At a first glance everything looks fine. However, if we pay closer attention to the fromBlock field we will notice that it has an invalid leading zero, which causes the node to reject the request due to invalid parameters.

My guess is that this issue doesn't come up very often b/c most nodes must tolerate invalid "Quantity" fields. However, according to the official spec:

When encoding quantities (integers, numbers): encode as hex, prefix with "0x", the most compact representation (slight exception: zero should be represented as "0x0").

Another reason why I think that this issue doesn't come up often is because I've noticed that most of the times that the queries are created, the quantity fields come from the result of other requests, which are returning properly encoded Quantity fields.

[YuyaMaruyama21D4E]

Hello. I am also facing the same issue and am closely monitoring this issue.
I believe resolving this problem is crucial for many users. I would greatly appreciate any progress on this matter.

[FYI]
Related issue in metamask-extension repository:

• eth_getLogs: invalid argument 0: hex number with leading zero digits metamask-extension#8220

[legobeat]

Related:

• fix: use BN from bn.js instead of ethereumjs-util metamask-extension#28146
  • fix: upgrade from ethereumjs-util to @ethereumjs/util metamask-extension#28169
• fix: remove usage of bn.js v4 metamask-mobile#12043
  • fix(deps): unpin [email protected],x [email protected] metamask-mobile#11972