Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do we pad uneven length hex numbers with leading zeros? #152

Closed
BelfordZ opened this issue Mar 27, 2024 · 3 comments
Closed

Why do we pad uneven length hex numbers with leading zeros? #152

BelfordZ opened this issue Mar 27, 2024 · 3 comments
Labels
team-wallet-api-platform

Comments

@BelfordZ
Copy link

Can anyone tell me why?
https://github.com/MetaMask/eth-json-rpc-filters/blob/main/hexUtils.js#L55

This is causing tests against https://github.com/ethereum/execution-apis to fail (expects hex number that is not zero-leading)
@shanejonas
Copy link

geth and the spec no longer support leading 0s

rel ethereum/execution-apis#40 (comment)
rel NomicFoundation/hardhat#1585 (comment)

@shanejonas
Copy link

rel #71
rel #70

@mcmire
Copy link
Contributor

mcmire commented Oct 25, 2024

Closing this issue as it's just a question, but leaving this here for reference of course.

@mcmire mcmire closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-api-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcmire @shanejonas @BelfordZ