Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test multiple XIOS versions #4

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

mo-marqh
Copy link
Member

This PR introduces a test matrix for CI testing

specifically: current LFRIC revision, head of XIOS2 trunk, head of XIOS3 trunk

(Note: the XIOS3 trunk is included with a patch for making transport configuration suitable for use with limited MPI on github CI runners.)

Copy link
Contributor

@mo-nabilbrice mo-nabilbrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow looks good to me!

I wonder whether there is an alternative to using cd. It seems like you have to manage the current working directory across multiple steps.

@mo-marqh
Copy link
Member Author

The workflow looks good to me!

I wonder whether there is an alternative to using cd. It seems like you have to manage the current working directory across multiple steps.

I agree, I think there should be better ways to handle this than dancing in and out of directories via cd

I know i've tried to avoid this in a number of places in the test runners

i'll make an issue to target looping back to this

@mo-nabilbrice mo-nabilbrice merged commit a8d5d79 into MetOffice:main Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants