Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codeowners file #71

Merged
merged 1 commit into from
Jul 9, 2024
Merged

add codeowners file #71

merged 1 commit into from
Jul 9, 2024

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Jul 9, 2024

Description

Twin of MetOffice/orca-jedi#103

The github CODEOWNERS file allows repository owners to specify owners of a repository or particular directories within a repo. This flexible approach allows automatic notification/addition of reviewers to pull requests relevant for that team or individual that is responsible for the repository. Later, we could add restrictions so that reviewers listed would have to accept the change before it could be merged, but I am not suggesting that right now.

Advantages:

  • guarantee that one of the reviewers has the ability to merge, meaning that we won't have any time between a change being marked accepted and merged.
  • the author of the PR would not have to figure out whose approval they need to get a change merged.

Issue(s) addressed

Experiment to implement suggestion in https://github.com/orgs/JCSDA-internal/discussions/144

@twsearle twsearle self-assigned this Jul 9, 2024
@twsearle twsearle merged commit 2dded66 into develop Jul 9, 2024
2 checks passed
@twsearle twsearle deleted the feature/add-codeowners-file branch July 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants