Code

Recursion handling#93

Code

Merged

andrewcoughtrie merged 146 commits intoMetOffice:mainMetOffice/Vernier:mainfrom mo-mglover:recursion-handlingCopy head branch name to clipboardAug 25, 2023

+241-11

Commits

Commits on Aug 24, 2022

• Farting the current output into a hard-coded file (#52)

  bencopl

  committed
  def154a

Commits on Aug 31, 2022

• Farting the current output into a hard-coded file (#52)

  bencopl

  committed
  2ed6823

• Merge branch '52-outputting-to-file' of github.com:MetOffice/profiler into 52-outputting-to-file

  bencopl

  committed
  8832dd5

• Merge branch '52-outputting-to-file' of github.com:MetOffice/profiler into 52-outputting-to-file

  bencopl

  committed
  c5d4b9d

Commits on Sep 1, 2022

• Merge branch '52-outputting-to-file' of github.com:MetOffice/profiler into 52-outputting-to-file

  bencopl

  committed
  696693b

• Support for setting the outfile name via an environment variable (#52)

  bencopl

  committed
  e436793

Commits on Sep 9, 2022

• MPI support, one output file per rank (#52)

  bencopl

  committed
  778b5de

Commits on Oct 4, 2022

• Farting the current output into a hard-coded file (#52)

  bencopl

  committed
  da26ea1

• Farting the current output into a hard-coded file (#52)

  bencopl

  committed
  4ca8a4b

• Support for setting the outfile name via an environment variable (#52)

  bencopl

  committed
  5edf819

• MPI support, one output file per rank (#52)

  bencopl

  committed
  338ddb1

• Merge branch '52-outputting-to-file' of github.com:MetOffice/profiler into 52-outputting-to-file

  bencopl

  committed
  44a7559

Commits on Oct 13, 2022

• Tidying up profiler's write function (#52)

  bencopl

  committed
  4a5f354

Commits on Oct 27, 2022

• Initial workflow [checking gcov works before messing with lcov] (#45)

  bencopl

  committed
  b916d29

• Cosmetic changes to yml file

  bencopl

  committed
  e61735d

• Fixing error messsage from actions tab

  bencopl

  committed
  db80d24

• Merge pull request #2 from bencopl/45-unit-test-coverage

  Show description for 1229a45
  bencopl

  authored
  1229a45

• Typo in yml file

  bencopl

  committed
  5b7172c

• Disabling doxygen, explicitly declaring compilers using matrix method

  bencopl

  committed
  2281558

• Including GTest

  bencopl

  committed
  639cc26

• Disabling fortran tests in cmake config

  bencopl

  committed
  d1739a9

• Altering gcov flags

  bencopl

  committed
  af8279a

• Attempting conda install of gcov and lcov

  bencopl

  committed
  b8dc143

• Merging into single job

  bencopl

  committed
  0a4bb78

• Fixed typo

  bencopl

  committed
  f1b7758

• Removing environment file line from conda setup

  bencopl

  committed
  ea03f9d

• Removing conda install of gcov

  bencopl

  committed
  1e34eaa

• Including conda forge channel

  bencopl

  committed
  ffeea84

• Attempting to fix lcov command not working by including shell -l {0} in workflow step

  bencopl

  committed
  db9f09a

• Also adding shell command to genhtml step, workflow should now run all the way through

  bencopl

  committed
  df89b09

• Trying default workspace option part-way through job

  bencopl

  committed
  683aaba

• Removing steps from line56

  bencopl

  committed
  c5849a5

• Added default shell

  bencopl

  committed
  ee78b36

• Removing defaults option...

  bencopl

  committed
  39de6d1

Commits on Oct 28, 2022

• Added step that updates github pages

  bencopl

  committed
  808be57

• Resolving unknown branch issue

  bencopl

  committed
  51d8c91

• Typo in final step

  bencopl

  committed
  020d4a7

• Removing git remote update line

  bencopl

  committed
  88e6628

• Fixing error msg when github tries to remove folder that isnt there

  bencopl

  committed
  0673329

• Removing git prefix from rm -rf

  bencopl

  committed
  ba54fbe

• Altering docs folder

  bencopl

  committed
  2939272

• Filtering out STL headers

  bencopl

  committed
  906910e

• Fixed typo in shell option

  bencopl

  committed
  4eb1ce4

• Attempt to include fortran tests

  bencopl

  committed
  336dc18

• Scrapping fortran tests

  bencopl

  committed
  37ac655

• Getting Doxygen AND coverage docs to appear

  bencopl

  committed
  afd98f4

• Merge pull request #3 from bencopl/45-unit-test-coverage

  Show description for 28dd901
  bencopl

  authored
  28dd901

• Fixed error in documentation.yml

  bencopl

  committed
  9f9de39

• Changing where doxygen documentation is put

  bencopl

  committed
  3807f79

• Testing putting both workflows straight into docs

  bencopl

  committed
  62b4cd8

• Separating them into documentation and coverage files

  bencopl

  committed
  eb12dfb

• Typo in coverage.yml

  bencopl

  committed
  cbb643a

• Another typo in coverage.yml

  bencopl

  committed
  dc2f0b4

• Hopefully final error with coverage.yml

  bencopl

  committed
  1590af5

Commits on Nov 3, 2022

• Overhead times reported from all threads.

  mo-mglover

  committed
  62d4585

• Draft of new IO structure contained within the two new files (#52)

  bencopl

  committed
  cbda186

• Formatting mostly there but not working with multiple threads (#70)

  bencopl

  committed
  c3a40d2

Commits on Nov 4, 2022

• Draft solution for combining all hashtables together (#70)

  bencopl

  committed
  0c6c8b0

Commits on Nov 8, 2022

• Added HashVec class that collects all hashtables, then sorts & writes entries (#70)

  bencopl

  committed
  46a6d11

• Adding banners and fixing includes (#70)

  bencopl

  committed
  9d56df8

• Switching to getter that returns a reference (instead of using pointers) (#70)

  bencopl

  committed
  2df6214

• Improved comments (#70)

  bencopl

  committed
  7c6fb2f

• Capture Fortran time (appending null character).

  mo-mglover

  committed
  3b378b8

Commits on Nov 9, 2022

• Adding in PLACEHOLDER block of info above table (#70)

  bencopl

  committed
  427b68a

• Switching to functions rather than single-method objects (#52)

  bencopl

  committed
  b169421

• Move post final gettime time updates to pointer / ref increments.

  mo-mglover

  committed
  91f430c

• Merge branch 'main' into 52-outputting-to-file

  bencopl

  committed
  cb7a77b

Commits on Nov 10, 2022

• Attempting to debug mpi issue in workflow (#52)

  bencopl

  committed
  dbc5a8a

• Installing mpich in workflow (#52)

  bencopl

  committed
  c7cb133

• Changing workflow step name to reflect mpich installation (#52)

  bencopl

  committed
  9cfa153

• Slight comment changes (#52)

  bencopl

  committed
  b4e32fd

• Printing mpich version within workflow (#52)

  bencopl

  committed
  6436572

• Trying to print OpenMP version (#52)

  bencopl

  committed
  a426c3b

• Updating readme with correct OpenMP version number (#52)

  bencopl

  committed
  244295f

• Merge pull request #4 from MetOffice/52-outputting-to-file

  Show description for af7b1f4
  bencopl

  authored
  af7b1f4

Commits on Nov 11, 2022

• Merge branch '70-mimic-drhooks-output' into 72-multiple-output-format-options (#72)

  bencopl

  committed
  db3e744

• Change the traceback from std::vector to std::array.

  mo-mglover

  committed
  cd1256b

• Catch the case where a stop calliper is called before a start calliper.

  mo-mglover

  committed
  f16bbc4

• Double stdfunction strategy pattern that includes ouput format (#72)

  bencopl

  committed
  28127da

Commits on Nov 21, 2022

• Correct handling of child time for top-level calls.

  mo-mglover

  committed
  588f264

Commits on Nov 22, 2022

• Draft of visitor pattern solution (#72)

  bencopl

  committed
  e7303b7

• Better comment blocks in visitor pattern solution (#72)

  bencopl

  committed
  e256b4e

• Slight change in how the visitor method is called (#72)

  bencopl

  committed
  a4c8914

Commits on Nov 24, 2022

• Combination of std::function and virtual strategy methods (#72)

  bencopl

  committed
  2d87e70

Commits on Nov 25, 2022

• Updating comment blocks (#72)

  bencopl

  committed
  472d045

• Tidying up and updating call count unit test (#72)

  bencopl

  committed
  20c258b

• Adding some const's where appropriate and slight comment changes (#72)

  bencopl

  committed
  c3f143f

Commits on Nov 28, 2022

• Modifying string concatenation (#72)

  bencopl

  committed
  ee43d2b

Commits on Nov 29, 2022

• Persistent entries for each region stored in vector; use iterators.

  mo-mglover

  committed
  3821115

• Fixing mistake in string concatenation (#72)

  bencopl

  committed
  32dd850

• Erroneous line in HashTable::append_to() (#72)

  bencopl

  committed
  1b82942

• Better timings - don't rehash the hashes (plus a few consts).

  mo-mglover

  committed
  4200288

• Changing final loop in call count unit test (#72)

  bencopl

  committed
  b8ebee4

• Removing accidental addition of new coverage worklow (#72)

  bencopl

  committed
  7329318

• Fixing documentation workflow based on removal of coverage one (#72)

  bencopl

  committed
  fa1c2ad

• Hopeful solution to call count unit test error (#72)

  bencopl

  committed
  75935db

• Modifications to query_insert()

  mo-mglover

  committed
  383fd34

Commits on Nov 30, 2022

• Altering call count test - removing pair from vector (#72)

  bencopl

  committed
  fa4e239

• Final tidying up (#72)

  bencopl

  committed
  060c551

• Index-based addressing for the vector. Sorting needs attention.

  mo-mglover

  committed
  165d09a

• Correct lookup_table's view of hashvec indices after sort.

  mo-mglover

  committed
  35e8859

Commits on Dec 2, 2022

• Separate sort method; TracebackEntry; other tweaks.

  mo-mglover

  committed
  da863ea

• Modified comment blocks, plus other tweaks.

  mo-mglover

  committed
  f0be730

Commits on Dec 5, 2022

• Remove unused variable.

  mo-mglover

  committed
  16b2955

• Don't include asserts that might trap application-level coding faults.

  mo-mglover

  committed
  d24c614

Commits on Jan 5, 2023

• Add test for case where traceback array exhausted.

  mo-mglover

  committed
  e8919a9

• Add [[maybe_unused]] in traceback entry exhaustion test.

  mo-mglover

  committed
  f059b78

• Merge branch 'main' into 64-better-overhead-measurement

  mo-mglover

  authored
  ff1774f

Commits on Jan 6, 2023

• Tidy up around start parts and namespacing threadprivate storage.

  mo-mglover

  committed
  73b179d

Commits on Jan 20, 2023

• Minor correction to commenting.

  mo-mglover

  committed
  cc44fd7

Commits on Feb 7, 2023

• Merging suggested changes from MG branch (#72)

  bencopl

  committed
  269bf2c

Commits on Feb 8, 2023

• Minor cosmetic/comment additions or adjustments (#72)

  bencopl

  committed
  7e4da7f

• Accidentally removed required include in last commit (#72)

  bencopl

  committed
  861d0eb

• Merge branch 'main' into 72-multiple-output-format-options

  bencopl

  authored
  0aad380

Commits on Feb 14, 2023

• Merge branch '72-multiple-output-format-options' into 64-better-overhead-management-merge72

  mo-mglover

  committed
  b718d07

Commits on Apr 19, 2023

• Merge branch 'main' into 64-better-overhead-management-merge72

  mo-mglover

  committed
  6f35fc1

Commits on Apr 20, 2023

• Corrections following merge of formatting changes on main.

  mo-mglover

  committed
  fce0d9a

• Add __profiler__ region name test, alongside tests for other regions.

  mo-mglover

  committed
  28694dd

Commits on Apr 24, 2023

• Move RegionRecord constructor.

  mo-mglover

  committed
  8cb8d71

Commits on May 5, 2023

• Working byte copying, with appropriate changes to unit tests.

  mo-mglover

  committed
  c708ac1

• Tweaks to typecasting (remove build warning messages).

  mo-mglover

  committed
  9e32240

• Use PROF_STRING_BUFFER_LENGTH.

  mo-mglover

  committed
  9e88a55

Commits on May 11, 2023

• Return overhead time pointers through argument list, not returned from functions.

  mo-mglover

  committed
  095e8dd

Commits on May 12, 2023

• Forward declare HashVecHandler; use hashvec_t in one place; TracebackEntry() = default.

  mo-mglover

  committed
  e8a40ac

• Corrections to doxygen comments.

  mo-mglover

  committed
  ff402ad

• Make start_part1 and start_part2 methods private in Profiler class.

  mo-mglover

  committed
  4e2a8c2

• Return overhead time pointers through argument list.

  mo-mglover

  committed
  d170cb4

Commits on May 13, 2023

• Remove extraneous hash of __profiler__.

  mo-mglover

  committed
  b128a8d

Commits on May 17, 2023

• add_child_time -> add_child_time_to_parent.

  mo-mglover

  committed
  928c5de

• reference -> pointer in comments in one place.

  mo-mglover

  committed
  ece55a7

Commits on May 18, 2023

• Merge branch '64-better-overhead-measurement' into 64-better-overhead-measurement-byte-copy

  mo-mglover

  committed
  5f5ccca

Commits on May 26, 2023

• Correct handling of total times with recursions

  Show description for b4f019a
  mo-mglover

  committed
  b4f019a

Commits on May 31, 2023

• File-scope variables become static data members.

  mo-mglover

  committed
  4dcc912

Commits on Jun 1, 2023

• Overloaded const and non-const hash2record. (Can have same name.)

  mo-mglover

  committed
  78ca084

• Merge branch '64-better-overhead-measurement' into byte-copy-thread-id

  mo-mglover

  committed
  bf7ee06

• Merge branch 'byte-copy-thread-id' into byte-copy-thread-id-and-recursion-total-time

  mo-mglover

  committed
  4265d61

Commits on Jun 2, 2023

• Add recursion test; handle recursion_total_time_ slightly differently.

  mo-mglover

  committed
  807b39a

Commits on Jul 25, 2023

• Merge branch 'main' into recursion-handling

  mo-mglover

  committed
  0ed7c87

Commits on Aug 23, 2023

• Merge branch 'main' into recursion-handling

  mo-mglover

  committed
  4ce4b2c

• Swap recursion level to unsigned int.

  mo-mglover

  committed
  a1e1170

• Add direct recursion test. Slacken time tolerance.

  mo-mglover

  committed
  339e75d

• Remove extraneous spaces.

  mo-mglover

  committed
  d85d26a

Commits on Aug 24, 2023

• Make test_recursion threadsafe.

  mo-mglover

  committed
  c5046c4

Commits on Aug 25, 2023

• Add doxygen comments for recursion increment / decrement.

  mo-mglover

  committed
  15aa1bd

• Remove forward declarations in test_recursion.

  mo-mglover

  committed
  341b88a

• Reinstate one forward declaration.

  mo-mglover

  committed
  b767e34