-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support pull
/push
/link
on multiple mermaid files at once
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Dec 1, 2023
Support pulling/pushing multiple files at once with the `@mermaidchart/cli` CLI, e.g. like `mermaid-chart pull file1 file2`.
Add support for running `mermaid-chart link diagram1.mmd diagram2.mmd`. The CLI tool will ask the user if they want to upload all diagrams to the same project. Otherwise it will ask the user for the correct project for each diagram: ```console $ npx @mermaidchart/cli link test/output/unsynced.mmd test/output/unsynced1.mmd ? Select a project to upload test/output/unsynced.mmd to personal ? Would you like to upload all 2 diagrams to this project? (Y/n) ```
Remove the `paths` var from `getProjectId()` function. This means we can keep track of which call is the first/second call, without needing a `paths` var (useful when we support diagrams without a path). Intead we use `Cache.previousSelectedProjectId` and `Cache.usePreviousSelectedProjectId`.
Micro-op, I'm mainly doing this so the code is cleaner, not so that the code is faster!
I did this in a separate commit from the previous one, in order to make the `git diff` easier to read for reviewers.
aloisklink
force-pushed
the
feat/add-mermaid-chart-cli
branch
from
March 6, 2024 16:12
c7b84c0
to
3211343
Compare
aloisklink
force-pushed
the
feat/support-multiple-files-at-once-in-cli
branch
from
March 6, 2024 16:15
834c3e6
to
8904bf8
Compare
This was referenced Apr 10, 2024
sidharthv96
approved these changes
Apr 16, 2024
Fix merge conflict in packages/cli/src/commander.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR: This PR is stacked on top of:
@mermaidchart/cli
CLI tool for accessing Mermaid Chart #12, which is stacked on top ofsetDocument(document)
API function #11, which is stacked on top ofdeleteDocument(documentID)
API func #10, which is stacked on top ofcreateDocument(projectID)
API function #9.Please change this PR to target
main
once #12 has been merged.📖 Description
Currently, the
mermaid-chart
CLI can onlypull
/push
/link
a single file at a time.This PR adds support for pulling/pushing/linking multiple files at once with the
@mermaidchart/cli
CLI, e.g. likemermaid-chart pull file1 file2
.If using
bash
, this means you can run commands likenpx mermaid-chart pull docs/*.mmd
, as your shell will automatically expanddocs/*.mmd
.link
-ing multiple filesWhen running
mermaid-chart link diagram1.mmd diagram2.mmd diagram3.mmd
, the mermaid-chart CLI will ask the user if they want to upload all the diagrams to the same project. If not, then the CLI will ask the user for the project for each diagram:push
/pull
-ing multiple filesWhen pulling/pushing multiple files, the CLI will print some info about each file: