-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r2rtf 1.1.1 #209
Merged
Merged
Release r2rtf 1.1.1 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
17 tasks
nanxstats
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear to me why the segment fault from running the test "Test the pageby rows are the last rows of a page" under macOS. I'd take this as a transient error and not a real issue for the release.
Expand logs
── Test failures ───────────────────────────────────────────────── testthat ────
> library(testthat)
> library(dplyr)
Attaching package: 'dplyr'
The following object is masked from 'package:testthat':
Error: Error: R CMD check found ERRORs
Execution halted
matches
The following objects are masked from 'package:stats':
filter, lag
The following objects are masked from 'package:base':
intersect, setdiff, setequal, union
> library(r2rtf)
> library(ggplot2)
>
> test_check("r2rtf")
*** caught segfault ***
address 0x0, cause 'unknown'
Traceback:
1: .Call(dplyr_lazy_vec_chop_impl, data, rows, private$env_current_group_info, private$grouped, private$rowwise)
2: initialize(...)
3: DataMask$new(data, by, verb, error_call = error_call)
4: summarise_cols(.data, dplyr_quosures(...), by, "summarise")
5: summarise.grouped_df(.tbl, !!!funs)
6: summarise(.tbl, !!!funs)
7: summarise_all(group_by(as.data.frame(attributes(as_rtf_pageby(x))), info.id), last)
8: mutate(summarise_all(group_by(as.data.frame(attributes(as_rtf_pageby(x))), info.id), last), row = substr(as.character(info.page), 1, 1))
9: eval(code, test_env)
10: eval(code, test_env)
11: withCallingHandlers({ eval(code, test_env) if (!handled && !is.null(test)) { skip_empty() }}, expectation = handle_expectation, skip = handle_skip, warning = handle_warning, message = handle_message, error = handle_error)
12: doTryCatch(return(expr), name, parentenv, handler)
13: tryCatchOne(expr, names, parentenv, handlers[[1L]])
14: tryCatchList(expr, names[-nh], parentenv, handlers[-nh])
15: doTryCatch(return(expr), name, parentenv, handler)
16: tryCatchOne(tryCatchList(expr, names[-nh], parentenv, handlers[-nh]), names[nh], parentenv, handlers[[nh]])
17: tryCatchList(expr, classes, parentenv, handlers)
18: tryCatch(withCallingHandlers({ eval(code, test_env) if (!handled && !is.null(test)) { skip_empty() }}, expectation = handle_expectation, skip = handle_skip, warning = handle_warning, message = handle_message, error = handle_error), error = handle_fatal, skip = function(e) { })
19: test_code(desc, code, env = parent.frame(), default_reporter = local_interactive_reporter())
20: test_that("Test the pageby rows are the last rows of a page", { x <- rtf_pageby(rtf_body(rtf_source(rtf_footnote(rtf_title(iris, "Title"), "Footnote"), "DataSource")), page_by = "Species", new_page = TRUE, pageby_header = FALSE) y <- mutate(summarise_all(group_by(as.data.frame(attributes(as_rtf_pageby(x))), info.id), last), row = substr(as.character(info.page), 1, 1)) z <- mutate(as.data.frame(table(x$Species)), cu = cumsum(Freq)) z <- mutate(z, cum = cu + as.numeric(rownames(z))) expect_equal(y$row, rownames(y)) expect_equal(y$info.index, z$cum) expect_false(all(y$info.pageby)) })
21: eval(code, test_env)
22: eval(code, test_env)
23: withCallingHandlers({ eval(code, test_env) if (!handled && !is.null(test)) { skip_empty() }}, expectation = handle_expectation, skip = handle_skip, warning = handle_warning, message = handle_message, error = handle_error)
24: doTryCatch(return(expr), name, parentenv, handler)
25: tryCatchOne(expr, names, parentenv, handlers[[1L]])
26: tryCatchList(expr, names[-nh], parentenv, handlers[-nh])
27: doTryCatch(return(expr), name, parentenv, handler)
28: tryCatchOne(tryCatchList(expr, names[-nh], parentenv, handlers[-nh]), names[nh], parentenv, handlers[[nh]])
29: tryCatchList(expr, classes, parentenv, handlers)
30: tryCatch(withCallingHandlers({ eval(code, test_env) if (!handled && !is.null(test)) { skip_empty() }}, expectation = handle_expectation, skip = handle_skip, warning = handle_warning, message = handle_message, error = handle_error), error = handle_fatal, skip = function(e) { })
31: test_code(test = NULL, code = exprs, env = env, default_reporter = StopReporter$new())
32: source_file(path, env = env(env), desc = desc, error_call = error_call)
33: FUN(X[[i]], ...)
34: lapply(test_paths, test_one_file, env = env, desc = desc, error_call = error_call)
35: doTryCatch(return(expr), name, parentenv, handler)
36: tryCatchOne(expr, names, parentenv, handlers[[1L]])
37: tryCatchList(expr, classes, parentenv, handlers)
38: tryCatch(code, testthat_abort_reporter = function(cnd) { cat(conditionMessage(cnd), "\n") NULL})
39: with_reporter(reporters$multi, lapply(test_paths, test_one_file, env = env, desc = desc, error_call = error_call))
40: test_files_serial(test_dir = test_dir, test_package = test_package, test_paths = test_paths, load_helpers = load_helpers, reporter = reporter, env = env, stop_on_failure = stop_on_failure, stop_on_warning = stop_on_warning, desc = desc, load_package = load_package, error_call = error_call)
41: test_files(test_dir = path, test_paths = test_paths, test_package = package, reporter = reporter, load_helpers = load_helpers, env = env, stop_on_failure = stop_on_failure, stop_on_warning = stop_on_warning, load_package = load_package, parallel = parallel)
42: test_dir("testthat", package = package, reporter = reporter, ..., load_package = "installed")
43: test_check("r2rtf")
An irrecoverable exception occurred. R is aborting now ...
1 error ✖ | 0 warnings ✔ | 0 notes ✔
Error: Process completed with exit code 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.