Skip to content

Commit

Permalink
Merge pull request #8 from Merck/doi-comments-news
Browse files Browse the repository at this point in the history
Add DOI to description, add cran-comments, and update news
  • Loading branch information
allenzhuaz authored Aug 26, 2022
2 parents 26c9f92 + 91d4ef2 commit fdc6b97
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 4 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
^LICENSES_THIRD_PARTY$
^LICENSE$
^\.github$
^cran-comments\.md$
9 changes: 6 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: gMCPLite
Title: Lightweight Graph Based Multiple Comparison Procedures
Version: 0.1.0
Version: 0.1.1
Authors@R: c(
person("Yalin", "Zhu", email = "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-3830-8660")),
Expand All @@ -17,8 +17,11 @@ Authors@R: c(
person("Merck & Co., Inc., Rahway, NJ, USA and its affiliates", role = "cph")
)
Description: A lightweight fork of 'gMCP' with functions for graphical
described multiple test procedures. Implements a flexible function
using 'ggplot2' to create multiplicity graph visualizations.
described multiple test procedures introduced in
Bretz et al. (2009) <doi:10.1002/sim.3495> and
Bretz et al. (2011) <doi:10.1002/bimj.201000239>.
Implements a flexible function using 'ggplot2' to create
multiplicity graph visualizations.
Contains instructions of multiplicity graph and graphical testing for
group sequential design, with necessary unit testing using 'testthat'.
License: GPL-3
Expand Down
12 changes: 12 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# gMCPLite 0.1.1

## Improvements

- Added method references DOI to the description field of the `DESCRIPTION` file.
- Removed redundant `\dontrun{}` from examples.
- Replaced `cat()` with `message()` where suppression options like `verbose` are
not available, except for printing raw R Markdown content in vignettes,
which requires `cat()`.
- Removed setting `options(warn=-1)` and `options(warn=0)` in function.
- Reset the user's `options()` in vignettes after changing it.

# gMCPLite 0.1.0

- Created a fork from gMCP 0.8-15 and removed Java dependencies.
Expand Down
13 changes: 13 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
This is a new release that fixed the issues in v0.1.0 identified by CRAN.

## R CMD check results

0 errors | 0 warnings | 1 note

## Improvements

* Added method references DOI to the description field of the DESCRIPTION file.
* Removed redundant \dontrun{} from examples.
* Replaced cat() with message() where suppression options like verbose are not available, except for printing raw R Markdown content in vignettes, which requires cat().
* Removed setting options(warn=-1) and options(warn=0) in function.
* Reset the user's options() in vignettes after changing it.
2 changes: 1 addition & 1 deletion man/gMCPLite-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit fdc6b97

Please sign in to comment.