Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Work around unsupported json_serializer and json_deserializer #32

Merged
merged 2 commits into from
Aug 9, 2023
Merged

fix: Work around unsupported json_serializer and json_deserializer #32

merged 2 commits into from
Aug 9, 2023

Conversation

edgarrmondragon
Copy link
Member

@edgarrmondragon edgarrmondragon commented Aug 8, 2023 •
edited
Loading

Closes #29

@edgarrmondragon edgarrmondragon force-pushed the fix/safe-engine-creation branch from 80a778c to 2a35ccc Compare August 8, 2023 23:56
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 8, 2023 23:58
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) August 9, 2023 00:04
pnadolny13
pnadolny13 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon thanks this worked for me!

@edgarrmondragon edgarrmondragon merged commit c1cbb8c into main Aug 9, 2023
@edgarrmondragon edgarrmondragon deleted the fix/safe-engine-creation branch August 9, 2023 13:12
@pnadolny13 pnadolny13 mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnadolny13 pnadolny13 pnadolny13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: TypeError: Invalid argument(s) 'json_serializer','json_deserializer' sent to create_engine()...
2 participants
@edgarrmondragon @pnadolny13