Remove User Preferences Handling from BatchXPDialog
#5550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the entire
setUserPreferences
method, along with associated imports.Storing preferences caused a lot of fragility with this system. It was very easy for a user to accidentally brick their Mass Training dialog by moving between different campaigns if those campaigns had different skill set ups. For example, if Campaign A had Piloting/Mek cap out at 8, while B had it cap out at 10. Moving from B to A could prevent the Mass Training dialog being used entirely if the user had their target level set to 9 or 10.
User preferences, in this instance, just stored the last known configuration for the Mass Training dialog. Given how few options there are - and the fact that it doesn't appear to have stored configurations on a per-skill basis - I opted to remove preferences entirely.
Fixes #5542