Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MML #1667: incorrect cargo bay minimum doors (MML side) #1669

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Fix MML #1667: incorrect cargo bay minimum doors (MML side) #1669

merged 2 commits into from
Dec 27, 2024

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Dec 27, 2024 •
edited
Loading

Fix for #1667, "Incorrect minimum doors required for cargo bays".

Corrects the UI elements which determine whether bays can be added, doors increased or decreased, and whether a unit with bays is valid or not, based on the matching PR for MegaMek.

NOTE: this PR will break MML until the MM PR is merged!

Testing:

  • Loaded units from original issue successfully.
  • Added various bays with 0 doors as default.
  • Reduced existing cargo bay doors to 0 without issue.
  • Saved and loaded updated units.
  • Ran all 3 projects' unit tests (with MM and MML patches applied)

Close #1667

@Sleet01 Sleet01 mentioned this pull request Dec 27, 2024
Merged
@Sleet01 Sleet01 requested a review from SJuliez December 27, 2024 06:06
@Sleet01 Sleet01 merged commit bedf027 into MegaMek:master Dec 27, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammerGS HammerGS HammerGS approved these changes

@SJuliez SJuliez Awaiting requested review from SJuliez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect minimum doors required for cargo bays
2 participants
@Sleet01 @HammerGS