Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inverts one function check #1663

Closed
wants to merge 1 commit into from

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Dec 10, 2024

This function is called inverted everywhere it is called, so I just simplified it.

This is part of the acs-autoresolve

To be merged together with the other acs-autoresolve branches.

@Scoppio Scoppio self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.16%. Comparing base (b99df8a) to head (dfc74fb).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1663   +/-   ##
========================================
  Coverage      2.16%   2.16%           
  Complexity      209     209           
========================================
  Files           268     268           
  Lines         30927   30927           
  Branches       5290    5290           
========================================
  Hits            669     669           
  Misses        30101   30101           
  Partials        157     157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Scoppio Scoppio closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants