Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor saveUnitList() to not make a new ClientGUI #1597

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

Simple refactor of a previous pull request to not make the print-queue dialog depend on ClientGUI.

Also sets the default filename of the new file to the name of the original file.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.13%. Comparing base (71b9139) to head (7ed709c).
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1597      +/-   ##
===========================================
- Coverage      2.13%   2.13%   -0.01%     
  Complexity      204     204              
===========================================
  Files           266     266              
  Lines         30697   30714      +17     
  Branches       5231    5235       +4     
===========================================
  Hits            656     656              
- Misses        29888   29905      +17     
  Partials        153     153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS
Copy link
Member

Conflicting files.

@SJuliez SJuliez merged commit 613e84f into MegaMek:master Sep 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants