Record sheet fixes and improvements #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
===========================================
+ Coverage 0.52% 0.65% +0.13%
- Complexity 49 64 +15
===========================================
Files 266 266
Lines 30481 30511 +30
Branches 5190 5200 +10
===========================================
+ Hits 160 201 +41
+ Misses 30280 30270 -10
+ Partials 41 40 -1 ☔ View full report in Codecov by Sentry. |
IllianiCBT
reviewed
Jul 26, 2024
IllianiCBT
reviewed
Jul 26, 2024
| @@ -155,23 +155,23 @@ public static List<PrintRecordSheet> createSheets(List<? extends BTObject> entit | |||
| } | |||
| } else if (unit instanceof BattleArmor) { | |||
| baList.add((BattleArmor) unit); | |||
| if (singlePrint || baList.size() > 4) { | |||
| if (singlePrint || PrintSmallUnitSheet.fillsSheet(baList, options)) { | |||
There was a problem hiding this comment.
I don't think it makes sense to add parentheses here. There's only one operator in the new expression, although the code that was here before could have used them.
IllianiCBT
reviewed
Jul 26, 2024
| PrintRecordSheet prs = new PrintSmallUnitSheet(baList, pageCount, options); | ||
| pageCount += prs.getPageCount(); | ||
| sheets.add(prs); | ||
| baList = new ArrayList<>(); | ||
| } | ||
| } else if (unit instanceof Infantry) { | ||
| infList.add((Infantry) unit); | ||
| if (singlePrint || infList.size() > (options.showReferenceCharts() ? 2 : 3)) { | ||
| if (singlePrint || PrintSmallUnitSheet.fillsSheet(infList, options)) { |
There was a problem hiding this comment.
And here. Though you probably get the point.
There was a problem hiding this comment.
Same here. a || b is fine, it doesn't need to be (a) || (b) unless a and b themselves have some operator in them.
IllianiCBT
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects several bug fixes and improvements that are somewhat related which I worked on at the same time.