CI Anti-Mek Gear #1396
Merged
CI Anti-Mek Gear #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See notes in MegaMek/megamek#5070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the MML side of adding anti-mek gear for conv. infantry, replacing the approach of only storing anti-mek in the skill value. The changes for this are minimal; in the UI I have removed the enable/disable of the anti-mek checkbox and rather let the unit be invalid (making feedback on the problem available) instead of blocking the checkbox. TestInfantry is updated in MM accordingly. (CIStructureTab and CIWeaponView)
As an aside, because I notice me opening the weight, cost and BV breakdowns so often, I made the status bar labels clickable (and they underline when hovered so people will hopefully notice) and show the respective breakdown when clicked. (ClickableLabel and StatusBar)
This requires the accompanying MegaMek/megamek#5070