Beast-mounted infantry record sheet improvements #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelbraginskiy
commented
Jan 1, 2024
| break; | ||
| case INF_MOTORIZED: | ||
| setTextField(MP_1, formatMovement(infantry.getWalkMP())); | ||
| setTextField(MODE_1, "Motorized"); | ||
| mp1 = formatMovement(infantry.getWalkMP()); |
There was a problem hiding this comment.
Is there a reason that this isn't formatGroundMp btw? I have no idea so I just left it.
|
"Can operate in vacuum" feels weird but what do I know, maybe the Orcas have oxygen tanks. |
|
Codewise all good. Hammer must approve RS changes. |
|
RS changes are good as well. Thanks for the PR |
SJuliez
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the information mentioned in #1358 to the record sheets for beast-mounted infantry.
Some of examples of the generated record sheets:
Edit by Juliez:
Fixes #1358