Summary view #1357
Merged
Summary view #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
neoancient
reviewed
Jan 2, 2024
| } else if (entity instanceof Tank) { | ||
| critLabel.setText(formatCrits(getTankArmorCrits(entity))); | ||
| } | ||
|
|
There was a problem hiding this comment.
Armor can also take up space on conventional and aerospace fighters. TestAero.AeroArmor gives the slot costs.
There was a problem hiding this comment.
OK, fighter armor slots are now shown. Also had to change a "new Aero()" to "new AeroSpaceFighter()"
neoancient
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds availability info in the summary view on the main tab.
Again, these are a lot of code changes. The goal was to have the code not repeated for each unit type and so have the availability data present on all unit types that use the summary view (BA/CI don't). It is now organized such that each line in the summary is represented by its own object which implements SummaryItem and is responsible for updating the crits, weight and availability data. There is only one SummaryView class left that handles all unit types. For each unit type, the SummaryView is given whatever lines (=SummaryItems) that unit type uses during construction (see e.g. BMSTructureTab).
While the display as such works, there are numerous issues in the results that were present before and I did not correct; I probably added some as well. I think this is all outside this PR which is already big enough.