Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect minimum doors required for cargo bays #1667

Closed
7 tasks done
Setsul opened this issue Dec 20, 2024 · 1 comment · Fixed by #1669
Closed
7 tasks done

Incorrect minimum doors required for cargo bays #1667

Setsul opened this issue Dec 20, 2024 · 1 comment · Fixed by #1669
Assignees
Labels
Errata Good First Issue This is a good first issue for a new contributor Rules A game rule not properly implemented

Comments

@Setsul
Copy link

Setsul commented Dec 20, 2024

Prerequisites and Pre-Issue Checklist

  • I'm reporting the issue to the correct repository:

  • MegaMek

  • MegaMekLab

  • MekHQ

  • I've tested the issue against at least the latest MILESTONE version

  • I've asked on the MegaMek Discord about the error

  • I've reviewed the BattleTech rules and MegaMekLab documentation, and I've confirmed that something isn't working as intended.

  • I've searched the Github tracker and haven't found the issue listed

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

A: The number of Doors on a Cargo Bay on Large Craft can not be reduced below 1.
B: This can also cause an IllegalArgumentException on saved (canonical) units that possess Cargo Bays with 0 Doors.
C: This also makes it impossible to add further Cargo Bays to Large Craft that are using the maximum number of Doors.

Steps to Reproduce

A1. Add a Cargo Bay to a Large Craft.
A2. Try to reduce the number of Doors below 1.
A3. It won't work.

B1. Load any unit with a Cargo Bay with 0 Doors. E.g. Overlord (2762)
B2. Click on the Cargo Bay's number of Doors.
B3. IllegalArgumentException.

C1. Load any unit that uses its maximum number of Doors. E.g. Overlord (2762)
C2. Select Cargo as Bay type to add.
C3. "Add Bay" is unselectable/greyed out.

Cargo Bays are expected to behave like Infantry Bays, with no Doors being required.

Operating System *

Linux

Java Version *

Temurin 17.0.13+11

MegaMek Suite Version *

Free Text (type manually)

Custom MegaMekLab Version

v0.50.01

Attach Files

No response

Final Checklist

  • I've checked to make sure that this issue has not already been filed
  • I'm reporting only one issue in this ticket for clarity and focus
@Sleet01 Sleet01 added Errata Good First Issue This is a good first issue for a new contributor Rules A game rule not properly implemented labels Dec 20, 2024
@Sleet01
Copy link
Collaborator

Sleet01 commented Dec 20, 2024

This will likely need updates in two places:

  1. the MML UI, specifically around bays;
  2. the megamek/common/Bay.java class (and subclasses) where minimums and maximums are defined.

@Sleet01 Sleet01 self-assigned this Dec 26, 2024
Sleet01 added a commit that referenced this issue Dec 27, 2024
…nimum_doors_mml

Fix MML #1667: incorrect cargo bay minimum doors (MML side)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Errata Good First Issue This is a good first issue for a new contributor Rules A game rule not properly implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants