-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Tank armor and invalid builds #6343
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6343 +/- ##
=========================================
Coverage 28.97% 28.98%
- Complexity 14087 14089 +2
=========================================
Files 2673 2674 +1
Lines 269472 269480 +8
Branches 47967 47968 +1
=========================================
+ Hits 78087 78103 +16
+ Misses 187402 187397 -5
+ Partials 3983 3980 -3 ☔ View full report in Codecov by Sentry. |
a111eb3
to
fbebf76
Compare
fbebf76
to
957e8e5
Compare
megamek/unittests/megamek/common/loaders/BulkUnitFileTest.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; this will be a godsend.
Fixes issue MegamekLab #1674.
It makes sure the correct armor tech level is loaded when loading the tank or SV.
It also makes sure the correct tech level is persisted when saving the non-mek entity.
This also adds a list of reasons/justifications to why a canon unit build is invalid, and allows it to be loaded.
If the unit is changed in a way to make it lose its canon status (change the MUL to -1 or change the name to something that is not in the canon names list) it will stop saving the reasons list for the build fail.
Also adds a bulk file verification test for all units in MegaMek.
Fixes:
Implements:
Example of use in a BLK file: