Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6324: Prevent NPE when laser bays get mode count #6325

Merged

Conversation

psikomonkie
Copy link
Collaborator

@psikomonkie psikomonkie commented Dec 29, 2024

Fixes #6324

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.97%. Comparing base (654ed3f) to head (c8630a3).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6325   +/-   ##
=========================================
  Coverage     28.97%   28.97%           
- Complexity    14072    14074    +2     
=========================================
  Files          2672     2673    +1     
  Lines        269390   269409   +19     
  Branches      47955    47956    +1     
=========================================
+ Hits          78048    78060   +12     
- Misses       187372   187377    +5     
- Partials       3970     3972    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psikomonkie
Copy link
Collaborator Author

@kuronekochomusuke do you think this should wait until we figure out the cause of the xsteam errors, or should this be pushed on its own?

@kuronekochomusuke
Copy link
Collaborator

I am think maybe the other error caused the xstream one. it looks like EnumMap is in the allow list

or they are not setting the jvm parameters correctly when they launch it.

I created #6326 so we can see in the log in the future if they are setting the jvm parameters correctly

@psikomonkie psikomonkie marked this pull request as ready for review December 29, 2024 19:05
@kuronekochomusuke kuronekochomusuke merged commit eb5e538 into MegaMek:master Dec 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.2-SNAPSHOT] Spheroid DropShip air to ground attack causes NPE
2 participants