Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added reference to the log file inside gameLogger #6294

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Dec 20, 2024

This small change is necesary for #5454 on MHQ to show the game log of the auto resolved scenario for the user.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.95%. Comparing base (5bcc422) to head (b928f48).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6294   +/-   ##
=========================================
  Coverage     28.95%   28.95%           
- Complexity    14016    14017    +1     
=========================================
  Files          2672     2672           
  Lines        269237   269238    +1     
  Branches      47913    47913           
=========================================
+ Hits          77950    77953    +3     
+ Misses       187387   187385    -2     
  Partials       3900     3900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Scoppio Scoppio self-assigned this Dec 20, 2024
@HammerGS HammerGS merged commit 7f73674 into MegaMek:master Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants