fix: following suggestions of improvements from SJuliez #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6278 +/- ##
=========================================
Coverage 28.96% 28.96%
+ Complexity 14014 14013 -1
=========================================
Files 2670 2670
Lines 269128 269070 -58
Branches 47895 47892 -3
=========================================
- Hits 77942 77941 -1
+ Misses 187286 187228 -58
- Partials 3900 3901 +1 ☔ View full report in Codecov by Sentry. |
SJuliez
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following suggestions of improvements from SJuliez, this pull request reduces the number of duplicated code in the automatic generation of GUI for GM Commands, it also simplifies a function, and improves the java doc where it needs and removes some useless one.