Issue 4259: Fixing Dropship Heat-by-Arc for Players and Princess #6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grounded dropships to use individual weapons with heat-by-arc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6276 +/- ##
============================================
- Coverage 28.99% 28.95% -0.05%
- Complexity 13983 14016 +33
============================================
Files 2652 2672 +20
Lines 268306 269228 +922
Branches 47768 47910 +142
============================================
+ Hits 77803 77949 +146
- Misses 186620 187379 +759
- Partials 3883 3900 +17 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…grounded dropships to use individual weapons with heat-by-arc
…all-weapons' into issue-4259-princess-doesnt-fire-all-weapons
…event dereferences variable error
…rrentHeatBuildup for bays should use getHeatByBay
psikomonkie
changed the title
|
This is ready for review. I would appreciate a code review for this as it's more than just a trivial change. Thanks! |
Sleet01
reviewed
Dec 17, 2024
Sleet01
reviewed
Dec 17, 2024
megamek/src/megamek/client/ui/swing/unitDisplay/WeaponPanel.java
Outdated
Show resolved
Hide resolved
Sleet01
approved these changes
Dec 17, 2024
…sure non-large craft with bays will work
…prove Readability of statement
|
Thank you @Sleet01! I made some changes at your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4259
It works, Princess now fires as many weapons as she can when using the default Dropship heat rules, without going over the heat limit of dropships.
The original bug wasn't present (only using Aft weapons & the NPE), but Princess & grounded dropships were still doing funny stuff.
Bugs resolved: