Issue 1437: Check for stacking for elevation 0 Aeros during deployment #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on top of units
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6269 +/- ##
=========================================
Coverage ? 28.99%
Complexity ? 13982
=========================================
Files ? 2652
Lines ? 268306
Branches ? 47768
=========================================
Hits ? 77801
Misses ? 186623
Partials ? 3882 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1437
I believe it's correct to ignore the stacking penalties for airborne units at elevation 0 during the movement phase - this is what allows a dropship to land on top of units. During the deployment phase we don't want to allow the player to "crush" units.