feat: config interface extracted #6265
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| this(owner, name, FLOAT, defaultValue); | ||
| } | ||
|
|
||
| public Option(AbstractOptions owner, String name, Vector<String> defaultValue) { | ||
| @SuppressWarnings("unused") | ||
| public Option(IGameOptions owner, String name, Vector<String> defaultValue) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| boolean advancedAMS = false; | ||
| boolean advancedPD = false; | ||
| boolean advancedAMS; | ||
| boolean advancedPD; |
Check warning
Code scanning / CodeQL
Field masks field in super class Warning
Scoppio
force-pushed
the
game-options-interface
branch
2 times, most recently
from
fb116a8 to
0cbcfbd
Compare
Scoppio
force-pushed
the
game-options-interface
branch
from
0cbcfbd to
b28bb1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6265 +/- ##
=========================================
Coverage ? 28.99%
Complexity ? 13982
=========================================
Files ? 2652
Lines ? 268284
Branches ? 47761
=========================================
Hits ? 77797
Misses ? 186605
Partials ? 3882 ☔ View full report in Codecov by Sentry. |
| logger.error(ex, "Failed to start Server"); | ||
| logger.error("Failed to start Server", ex); |
There was a problem hiding this comment.
please ignore that I did this a couple of times, I am used to log4j formatting
| /** | ||
| * Returns a count of all options in this object. | ||
| * @return Option count. | ||
| */ | ||
| public int count() { | ||
| @Override | ||
| public int count() { |
There was a problem hiding this comment.
javadoc extracted to the interface
Extracted a new GameOptions interface for weapons, entities, etc, necessary to isolate the options in the autoresolve
Related
MegaMek/megameklab#1665