Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6224: NPE when air fails maneuver and flies off map #6253

Merged

Conversation

psikomonkie
Copy link
Collaborator

Fixes #6224
Fixes #6248

Just nudges the aircraft back onto the board. Aircraft that fly off normally still have their final position on the board, so this will work the same as that.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.99%. Comparing base (8ff043b) to head (087278c).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6253   +/-   ##
=========================================
  Coverage     28.99%   28.99%           
- Complexity    13984    13985    +1     
=========================================
  Files          2652     2652           
  Lines        268305   268299    -6     
  Branches      47768    47764    -4     
=========================================
+ Hits          77804    77805    +1     
+ Misses       186617   186611    -6     
+ Partials       3884     3883    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SJuliez SJuliez merged commit 20f7ea3 into MegaMek:master Dec 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants