Issue 6247:NPE with TacOps Energy Weapons when Changing Firing Mode

[psikomonkie]

Fixes #6247

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.99%. Comparing base (1c0e4ba) to head (5fb42e0).
Report is 64 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #6251   +/-   ##
=========================================
  Coverage     28.99%   28.99%           
- Complexity    13982    13985    +3     
=========================================
  Files          2652     2652           
  Lines        268308   268310    +2     
  Branches      47771    47767    -4     
=========================================
+ Hits          77799    77805    +6     
+ Misses       186627   186622    -5     
- Partials       3882     3883    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[neoancient]

I forgot about the option to change the power level. It's up in EnergyWeapon where I didn't see it.
Rather than hide half the options and assume they will be the correct ones, you could count how many don't start with pulse: return (int) modes.stream().filter(mode -> !mode.getName().startsWith("Pulse")).count(); It has to be cast to int because Stream::count returns long. This requires that the pulse modes are all added last, which is currently the case but it should be pointed out in a comment.

As for adding the modes, I think it might be best for all the removals to be handled by EnergyWeapon. Adding the line removeMode("Pulse Damage " + dmg); after removeMode("Damage " + dmg); would do it and would have no effect if the mode doesn't exist. Then in LaserWeapon::adaptToGameOptions any damage modes have already been added when super was invoked, so we could add the possible pulse modes with

            if (modes.isEmpty()) {
                addMode("");
                addMode("Pulse");
            } else {
                for (var mode : modes) {
                    addMode("Pulse " + mode.getName());
                }
            }

I didn't actually try any of this code to test it.

[psikomonkie]

Thank you so much neoancient! That was really helpful guidance.