Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1619 RFE: dirt and gravel roads #6246

Merged

Conversation

psikomonkie
Copy link
Collaborator

@psikomonkie psikomonkie commented Dec 6, 2024

Resolves #1619
Resolves #5595

Contains new graphics for gravel roads (from stonewall072) and dirt roads (Morkath)

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.99%. Comparing base (458ae46) to head (1ddd055).
Report is 62 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6246      +/-   ##
============================================
- Coverage     28.99%   28.99%   -0.01%     
- Complexity    13982    13984       +2     
============================================
  Files          2652     2652              
  Lines        268282   268314      +32     
  Branches      47762    47773      +11     
============================================
+ Hits          77799    77805       +6     
- Misses       186601   186627      +26     
  Partials       3882     3882              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS
Copy link
Member

HammerGS commented Dec 6, 2024

Do we need art for this?

@psikomonkie
Copy link
Collaborator Author

Do we need art for this?

No & Yes.

No, we don't need art for this to function. Currently a dirt road and gravel road look the same, but they function as they're supposed to.

Yes, I think we'll want art for gravel.

I do not think we should hold off on merging this PR until we have gravel road art as the gravel roads art is purely decorative and won't effect the functionality of this. Gravel & Dirt roads should not show up during map generation, they should only appear if a map maker uses it.

@psikomonkie
Copy link
Collaborator Author

Now includes art for gravel and dirt roads. Dirt roads use the art made by Morkath for #5595 and gravel roads use art made by stonewall072 for #1619

Thanks!

@HammerGS HammerGS merged commit 5e4b9f5 into MegaMek:master Dec 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants