Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new GM commands and client commands [WIP] #6242

Closed
wants to merge 4 commits into from

fix: ignore player votes

f9adf19
Select commit
Loading
Failed to load commit list.
Closed

feat: new GM commands and client commands [WIP] #6242

fix: ignore player votes
f9adf19
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Dec 5, 2024 in 7s

21 new alerts

New alerts in code changed by this pull request

  • 12 warnings
  • 9 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 114 in megamek/src/megamek/client/ui/swing/commands/ClientCommandPanel.java

See this annotation in the file changed.

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 13 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.

Check notice on line 263 in megamek/src/megamek/client/ui/swing/commands/ClientCommandPanel.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'coordX' is never used.

Check notice on line 271 in megamek/src/megamek/client/ui/swing/commands/ClientCommandPanel.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'coordY' is never used.

Check notice on line 287 in megamek/src/megamek/client/ui/swing/commands/ClientCommandPanel.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'playerArgument' is never used.

Check notice on line 297 in megamek/src/megamek/client/ui/swing/commands/ClientCommandPanel.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'unitArgument' is never used.

Check notice on line 313 in megamek/src/megamek/client/ui/swing/commands/ClientCommandPanel.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'teamArgument' is never used.

Check notice on line 69 in megamek/src/megamek/common/event/GameListener.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'e' is never used.

Check warning on line 369 in megamek/src/megamek/common/weapons/AreaEffectHelper.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
hex
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
hex
Loading
may be null at this access because of
this
Loading
null argument.
Variable
hex
Loading
may be null at this access because of
this
Loading
null argument.
Variable
hex
Loading
may be null at this access because of
this
Loading
null argument.

Check warning on line 415 in megamek/src/megamek/common/weapons/AreaEffectHelper.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
hex
Loading
may be null at this access as suggested by
this
Loading
null guard.
Variable
hex
Loading
may be null at this access because of
this
Loading
null argument.
Variable
hex
Loading
may be null at this access because of
this
Loading
null argument.
Variable
hex
Loading
may be null at this access because of
this
Loading
null argument.

Check warning on line 119 in megamek/src/megamek/common/weapons/ArtilleryBayWeaponIndirectFireHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 156 in megamek/src/megamek/common/weapons/ArtilleryBayWeaponIndirectFireHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 71 in megamek/src/megamek/common/weapons/ArtilleryWeaponIndirectFireHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 71 in megamek/src/megamek/common/weapons/ArtilleryWeaponIndirectFireHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
ammoType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 110 in megamek/src/megamek/common/weapons/ArtilleryWeaponIndirectFireHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check notice on line 141 in megamek/src/megamek/common/weapons/ArtilleryWeaponIndirectFireHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Unread local variable Note

Variable 'Entity ammoCarrier' is never read.

Check warning on line 245 in megamek/src/megamek/common/weapons/ArtilleryWeaponIndirectFireHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
ammoType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 123 in megamek/src/megamek/common/weapons/MekMortarAirburstHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 114 in megamek/src/megamek/common/weapons/MekMortarFlareHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 115 in megamek/src/megamek/common/weapons/MekMortarSmokeHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check warning on line 124 in megamek/src/megamek/common/weapons/MissileMineClearanceHandler.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
weaponType
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check notice on line 401 in megamek/src/megamek/server/totalwarfare/TWGameManager.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
TWGameManager.legacyProcessTeamChangeRequest
Loading
should be avoided because it has been deprecated.