Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow fleeing at end of movement #6230

Merged
merged 13 commits into from
Nov 29, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Nov 28, 2024

  • allow fleeing at end of movement, if you have remaining movement
  • check that unit made it to board edge before fleeing
  • update report log, show direction that the unit retreated

image
image
image
image
image

fixes #346

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.99%. Comparing base (f975114) to head (84ffea3).
Report is 49 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6230      +/-   ##
============================================
- Coverage     29.01%   28.99%   -0.02%     
+ Complexity    13985    13982       -3     
============================================
  Files          2649     2652       +3     
  Lines        268172   268281     +109     
  Branches      47734    47761      +27     
============================================
- Hits          77802    77799       -3     
- Misses       186484   186600     +116     
+ Partials       3886     3882       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT
Copy link
Collaborator

This is amazing!

@kuronekochomusuke kuronekochomusuke marked this pull request as draft November 28, 2024 14:18
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review November 28, 2024 15:20
@UlyssesSockdrawer
Copy link
Collaborator

Will this also check if the unit attempting to flee has at least one MP remaining to complete the move 'offboard'?

@kuronekochomusuke
Copy link
Collaborator Author

no, it just checks if you can make it to the edge of the board.

@HammerGS
Copy link
Member

Let me know if this is ready to go?

@kuronekochomusuke
Copy link
Collaborator Author

yea, it is ready now

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limited testing and seems to work.

@HammerGS HammerGS merged commit e371f22 into MegaMek:master Nov 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ground Units able to flee if they have the MP
4 participants