Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ulysses - 0.50 maps import #6188

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

UlyssesSockdrawer
Copy link
Collaborator

Adding my new maps from 0.50 to the repo for distribution.

Adding my new maps from 0.50 to the repo for distribution.
@UlyssesSockdrawer
Copy link
Collaborator Author

I've requested a review on this one because when pushing the files it highlighted some tags getting removed in maps that might've already been added to the distro by Hammer. Not sure if there's been map editor code changes that I need to go and resave the maps against.

Let me know if an issue. :)

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.17%. Comparing base (a7bb1b4) to head (576f4d8).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6188   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
+ Complexity    13971    13969    -2     
=========================================
  Files          2628     2628           
  Lines        266564   266539   -25     
  Branches      47575    47565   -10     
=========================================
- Hits          77771    77768    -3     
+ Misses       184910   184888   -22     
  Partials       3883     3883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS
Copy link
Member

HammerGS commented Nov 8, 2024

We always run the board tagger on the new maps so any missing with get added.

@HammerGS HammerGS merged commit ef8d32c into MegaMek:master Nov 9, 2024
7 checks passed
@HammerGS HammerGS added the Data Hammertime. label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Hammertime.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants