Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save patchwork armor with right tech level #6078

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

@pavelbraginskiy pavelbraginskiy commented Oct 7, 2024

Saving a mixed-tech unit with patchwork armor often results in nonsense in the MTF file like "Clan Heavy Ferro-Fibrous (Inner Sphere)". This armor fails to load and falls back to Standard Armor.

This PR fixes the code to save the tech level of the armor, not of the mech.

See also MegaMek/megameklab#1634, which fixes a different bug in MML that causes the same problem through an unrelated mistake.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.11%. Comparing base (a8d595a) to head (34e042c).
Report is 17 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6078      +/-   ##
============================================
- Coverage     29.11%   29.11%   -0.01%     
+ Complexity    13978    13977       -1     
============================================
  Files          2601     2601              
  Lines        267075   267092      +17     
  Branches      47743    47749       +6     
============================================
+ Hits          77767    77768       +1     
- Misses       185403   185417      +14     
- Partials       3905     3907       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 60ca23b into MegaMek:master Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants