Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1486 Add option to skip firing turn for mechs/vees that sprint #6062

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

DM0000
Copy link
Contributor

@DM0000 DM0000 commented Oct 4, 2024

added check for sprint and TSM in isEligibleForFiring

Only meks with TSM won't be skipped if option is checked

Closes #1486

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.06%. Comparing base (bc96356) to head (ef8b224).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6062      +/-   ##
============================================
- Coverage     29.06%   29.06%   -0.01%     
+ Complexity    13981    13980       -1     
============================================
  Files          2600     2600              
  Lines        267586   267592       +6     
  Branches      47791    47795       +4     
============================================
- Hits          77771    77770       -1     
- Misses       185913   185915       +2     
- Partials       3902     3907       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickAragua
Copy link
Member

What's special about TSM?

Also, what about industrial TSM?

@DM0000
Copy link
Contributor Author

DM0000 commented Oct 4, 2024

So TSM users can fire weapons to keep heat up. They should have 0% accuracy with "You have sprinted" msg. I can add in the industrial check.

@NickAragua
Copy link
Member

Per "Sprinting" on page 16 of TO: AR, I'm pretty sure sprinting completely disallows weapons firing, so I don't think allowing weapons fire is the right approach here.

@gsparks3
Copy link
Collaborator

gsparks3 commented Oct 4, 2024

Per "Sprinting" on page 16 of TO: AR, I'm pretty sure sprinting completely disallows weapons firing, so I don't think allowing weapons fire is the right approach here.

In the exact same passage:

[...] may still fire weapons to generate heat, though such firing has no chance of doing damage.

@NickAragua
Copy link
Member

Wow, never realized that. All right, good to go then.

@HammerGS HammerGS merged commit d80c42a into MegaMek:master Oct 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Add option to skip firing turn for mechs/vees that sprint
4 participants