Improved StratConSkillGenerator
#6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the skill generation logic in StratConSkillGenerator to streamline skill level calculations and removed redundant bonus handling. Also cleaned up logging in AtBDynamicScenarioFactory and removed an unnecessary skill generator type setting.
A random dice roll was introduced to adjust the skill level in the StratConSkillGenerator class. A roll of 1 decreases the skill level while a roll of 6 increases it. This change aims to introduce more variability to skill level determination.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6021 +/- ##
=========================================
Coverage 29.10% 29.10%
- Complexity 13972 13974 +2
=========================================
Files 2580 2580
Lines 267143 267141 -2
Branches 47711 47712 +1
=========================================
+ Hits 77743 77746 +3
+ Misses 185502 185495 -7
- Partials 3898 3900 +2 ☔ View full report in Codecov by Sentry. |
SJuliez
approved these changes
Sep 21, 2024
|
@IllianiCBT Leaving this to you to merge whenever you think it should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the mm half of MegaMek/mekhq#4865 and fixes an oversight in the implementation of the
StratConSkillGeneratorrandom skill generator. It now does all steps, with fewer reliances onTotalWarfareSkillGeneratormethods that were previously causing issues.