Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak princess gravity PSR handling #5864

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Aug 6, 2024

This increases Princess's caution when moving on maps with high or low gravity:

  • On low-gravity ground maps, ground units will recognize the PSR danger of exceeding their normal Run / Flank / Jump MP
  • On high-gravity ground maps, ground units will recognize the PSR danger of using jump MPs, but Run / Flank will not be penalized.

Also reverted an inadvertent change to the Low/High-G nag checks that I did during the bog-down work.
Additionally, reverts MoveStep.java to space-based indentation.

Testing:

  • Ran 12 v 12 bot matches with VTOL, hover, ground tank, and fast Light 'mechs (with and without jumping) to compare low- and high-gravity performance across various G levels.
  • Ran all 3 projects' unit tests.

@Sleet01 Sleet01 requested a review from pheonixstorm August 6, 2024 00:54
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.98%. Comparing base (cab504f) to head (8bab678).
Report is 134 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5864      +/-   ##
============================================
- Coverage     28.98%   28.98%   -0.01%     
- Complexity    13909    13913       +4     
============================================
  Files          2512     2512              
  Lines        267229   267321      +92     
  Branches      47780    47806      +26     
============================================
+ Hits          77462    77473      +11     
- Misses       185817   185894      +77     
- Partials       3950     3954       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 requested a review from NickAragua August 7, 2024 18:52
@Sleet01 Sleet01 merged commit d33a276 into MegaMek:master Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants