Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Gender Enum to Include 'Other' Genders #5863

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Cleaned up the class and added handlers for personnel with one of two 'Other' genders.

This PR does nothing with this functionality, it is added with a mind towards being used by another mhq-origin PR.

Cleaned up the class and added handlers for personnel with one of two 'Other' genders
@IllianiCBT IllianiCBT self-assigned this Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.98%. Comparing base (cab504f) to head (4ef8fe7).
Report is 118 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5863      +/-   ##
============================================
- Coverage     28.98%   28.98%   -0.01%     
  Complexity    13909    13909              
============================================
  Files          2512     2512              
  Lines        267229   267231       +2     
  Branches      47780    47780              
============================================
  Hits          77462    77462              
- Misses       185817   185819       +2     
  Partials       3950     3950              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IllianiCBT IllianiCBT merged commit 5d2f648 into MegaMek:master Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants