-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak automatic munition selection for low-ammo-count Autocannons #5860
Tweak automatic munition selection for low-ammo-count Autocannons #5860
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5860 +/- ##
============================================
- Coverage 28.99% 28.98% -0.02%
+ Complexity 13930 13908 -22
============================================
Files 2512 2512
Lines 267289 267254 -35
Branches 47837 47787 -50
============================================
- Hits 77510 77467 -43
- Misses 185829 185830 +1
- Partials 3950 3957 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reduce copy-pasta a little bit.
Roping in @IllianiCBT as they are some fresher eyes on the project, and have not worked on this code before. Do you mind taking a look at my proposed code, and @NickAragua 's suggested fix? |
private static boolean setAC10Imperatives(Entity e, MunitionTree mt, ReconfigurationParameters rp) { | ||
int ac10Count = getACWeaponCount(e, "10"); | ||
|
||
// TODO: remove this block when implementing new anti-ground Aero errata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know @Algebro7 is implementing some of the new Aero errata, but I don't know if they're doing the anti-ground errata. Tagging them here so that they're aware of this TODO (in case there is any cross-over).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: anyone working on this will also need to touch the other MM, MML, and MHQ ammo validation code - it's not a small lift.
So I took a look, but I really don't feel qualified to make a decision given the substantially more experience you both have over me. |
Alright, thanks for giving it a look-over. |
a4b3e17
to
4a08954
Compare
QA testing revealed that some units with single bins of AC10 and AC5 ammo would get Precision Autocannon munitions loaded, despite this significantly decreasing their mission endurance.
The issue was caused by a couple things:
Testing fixes for 1 and 2 revealed an opportunity to extend the Caseless ammo selection code for AC/20s to specific AC/10 and AC/5 situations as well.
Testing: