Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OptionsConstants instead of hard-coded strings #5859

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Aug 5, 2024

I found a few more instances in the codebase where game options were being queried with hard-coded strings rather than using the OptionsConstants enum. This was using a find all for game.getOptions()--I checked all of them and I believe these are the last.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.98%. Comparing base (9399938) to head (cab504f).
Report is 124 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5859      +/-   ##
============================================
- Coverage     29.05%   28.98%   -0.08%     
+ Complexity    13911    13909       -2     
============================================
  Files          2507     2512       +5     
  Lines        266366   267229     +863     
  Branches      47621    47780     +159     
============================================
+ Hits          77402    77462      +60     
- Misses       185025   185817     +792     
- Partials       3939     3950      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit 331c7fe into MegaMek:master Aug 5, 2024
5 checks passed
@Algebro7 Algebro7 deleted the options-constants branch August 5, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants