Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5851 and other UI issues from Simon #5854

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Aug 5, 2024

Fixes two issues reported by @SimonLandmine, corrects a style bug that IDEA complains about, and adds one set of client setting controls:

  1. Close [0.49.19.1] Default f-key hotkeys for Unit Display tabs in wrong order #5851 : Weapons and Systems tabs in the Unit Display reversed (F5 and F4, respectively)
  2. Fixes unfiled bug: Unit Display tab switches to Weapons tab during Weapon Attack phase, but not to Summary tab during Movement phase.
  3. Corrects an issue IDEA was bugged by: checking a string's equality to the empty string "" instead of calling .isEmpty()
  4. Adds checkboxes in the Autodisplay tab of Client Settings to control the tab switching behavior from 2. above.

Testing:

  • Various actions in the UI throughout test games to verify correct behavior of points 1, 2, and 4.
  • Ran all 3 projects' unit tests

Note: another issue that had not been filed against 0.49.19.1 (to wit: sub-windows consuming the <CTRL> + <ENTER> key combo) has already been fixed by @SJuliez excellent UI updates.

@Sleet01 Sleet01 requested a review from SJuliez August 5, 2024 00:35
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.97%. Comparing base (a55a508) to head (c03a68c).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5854      +/-   ##
============================================
- Coverage     28.99%   28.97%   -0.03%     
+ Complexity    13930    13910      -20     
============================================
  Files          2512     2512              
  Lines        267289   267330      +41     
  Branches      47837    47843       +6     
============================================
- Hits          77510    77465      -45     
- Misses       185829   185916      +87     
+ Partials       3950     3949       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

megamek/src/megamek/client/ui/swing/ChatterBox.java Outdated Show resolved Hide resolved
@Sleet01 Sleet01 merged commit 28ecfac into MegaMek:master Aug 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.49.19.1] Default f-key hotkeys for Unit Display tabs in wrong order
2 participants